Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Chromium/WebExtension: Fix warning - #12776

Closed
genodeftest wants to merge 2 commits into
EFForg:masterfrom
genodeftest:patch-1
Closed

genodeftest wants to merge 2 commits into
EFForg:masterfrom
genodeftest:patch-1

Conversation

@genodeftest

Copy link
Copy Markdown

This warning (see #12775 for details) is caused by not specifying browser_style in the browser_action section.

This change has been tested on Firefox 55.0.3, but not on any other version. It is not tested on Firefox ESR or Chromium at all.
Fixes #12775

This warning (see #12775 for details) is caused by not specifying `browser_style` in the `browser_action` section.
@J0WI

J0WI commented Dec 17, 2017

Copy link
Copy Markdown
Contributor

This might be something to look at before the next release. @Hainish

@Giltyhub

Copy link
Copy Markdown
Contributor

@genodeftest Can you resolve the conflict?

@Hainish

Hainish commented Apr 26, 2018

Copy link
Copy Markdown
Member

@bcyphers can you look at this?

Comment thread chromium/manifest.json Outdated
@@ -25,6 +25,7 @@
},
"default_popup": "pages/popup/index.html",
"default_title": "__MSG_about_ext_name__"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this just needs a comma at the end

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's what I broke.

@genodeftest

Copy link
Copy Markdown
Author

@Giltyhub : Conflict resolved.

@bcyphers : Done, comma is now added. Sorry this took me so long.

The tests fail in test/selenium/test_options.py::OptionsTest::test_show_counter FAILED for stable firefox and chrome beta, but I don't know whether this is related to my code changes.

@Giltyhub

Giltyhub commented Jun 3, 2018 •

Copy link
Copy Markdown
Contributor

@genodeftest thanks for solving the conflict! travis ci fail most probably is #15239 try to close then re-open to re-trigger the ci test until you it no longer fails

@genodeftest genodeftest closed this Jun 3, 2018
@genodeftest genodeftest reopened this Jun 3, 2018
@genodeftest genodeftest closed this Jun 3, 2018
@genodeftest genodeftest reopened this Jun 3, 2018
@genodeftest genodeftest closed this Jun 3, 2018
@genodeftest genodeftest reopened this Jun 3, 2018
@genodeftest

Copy link
Copy Markdown
Author

@Giltyhub : Thanks for this tip. After wasting a few cpu hours the checks finally passed.

@Hainish

Hainish commented Jun 8, 2018

Copy link
Copy Markdown
Member

@bcyphers please review

@bcyphers

bcyphers commented Jun 13, 2018 •

Copy link
Copy Markdown
Contributor

I was unable to reproduce #12775 in the latest firefox or chrome, but it looks like the bug is fixed in 55.0.3 and everything else still works. Good to go.

@J0WI

J0WI commented Jun 13, 2018

Copy link
Copy Markdown
Contributor

What about Tor/Firefox ESR?

@pipboy96

pipboy96 commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

I can no longer reproduce the warning in Chrome, FF and Tor Browser.

@pipboy96 pipboy96 closed this Jun 5, 2019
@genodeftest
genodeftest deleted the patch-1 branch November 25, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning about missing specification of browser_style

7 participants