Repository navigation
Chromium/WebExtension: Fix warning - #12776
genodeftest wants to merge 2 commits into
Conversation
This warning (see #12775 for details) is caused by not specifying `browser_style` in the `browser_action` section.
|
This might be something to look at before the next release. @Hainish |
|
@genodeftest Can you resolve the conflict? |
|
@bcyphers can you look at this? |
| @@ -25,6 +25,7 @@ | |||
| }, | |||
| "default_popup": "pages/popup/index.html", | |||
| "default_title": "__MSG_about_ext_name__" | |||
There was a problem hiding this comment.
Looks like this just needs a comma at the end
|
@genodeftest thanks for solving the conflict! travis ci fail most probably is #15239 try to close then re-open to re-trigger the ci test until you it no longer fails |
|
@Giltyhub : Thanks for this tip. After wasting a few cpu hours the checks finally passed. |
|
@bcyphers please review |
|
I was unable to reproduce #12775 in the latest firefox or chrome, but it looks like the bug is fixed in 55.0.3 and everything else still works. Good to go. |
|
What about Tor/Firefox ESR? |
|
I can no longer reproduce the warning in Chrome, FF and Tor Browser. |
This warning (see #12775 for details) is caused by not specifying
browser_stylein thebrowser_actionsection.This change has been tested on Firefox 55.0.3, but not on any other version. It is not tested on Firefox ESR or Chromium at all.
Fixes #12775